Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): improve rule dx #1516

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Feb 27, 2024

Description

  • Improve experience when skiping rules and when rules cannot be downloaded.
  • Set exit code to failure when no rules are found when it would be otherwise expected.

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger marked this pull request as draft February 27, 2024 11:47
@gotbadger gotbadger force-pushed the feat/improve-rules-args-handling branch from 0efa92c to d79dd5b Compare February 27, 2024 11:56
@gotbadger gotbadger force-pushed the feat/improve-rules-args-handling branch from d79dd5b to 6091429 Compare February 27, 2024 12:39
@gotbadger gotbadger marked this pull request as ready for review February 27, 2024 12:49
@gotbadger gotbadger merged commit adfe84c into main Feb 27, 2024
12 checks passed
@gotbadger gotbadger deleted the feat/improve-rules-args-handling branch February 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants