Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more scan context for gitlab #1464

Merged
merged 2 commits into from
Jan 15, 2024
Merged

feat: add more scan context for gitlab #1464

merged 2 commits into from
Jan 15, 2024

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Jan 12, 2024 •
edited
Loading

Description

Add more scan context for gitlab, use IID for pull request.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger requested a review from cfabianski January 12, 2024 15:30
cfabianski
cfabianski approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tests are green

@gotbadger gotbadger force-pushed the feat/improve-gitlab-ci-context branch from 73aecd7 to 973a7ae Compare January 12, 2024 16:59
@gotbadger gotbadger requested a review from cfabianski January 15, 2024 12:42
cfabianski
cfabianski approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😘

@gotbadger gotbadger merged commit 918c410 into main Jan 15, 2024
8 checks passed
@gotbadger gotbadger deleted the feat/improve-gitlab-ci-context branch January 15, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotbadger @cfabianski