docs: improve commands generation #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfabianski
force-pushed
the
improve-documentation
branch
from
93febc3 to
001bcd8
Compare
cfabianski
force-pushed
the
improve-documentation
branch
from
001bcd8 to
3caee3a
Compare
didroe
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1410 #1245
Improve the doc generation.
I needed to have an accessor to the env variables defined in viper so I forked Viper and I made those changes spf13/viper@f9bd0ac
Another approach would have been not rely on the Cobra commands at all and instead use only the code and Flags we defined ourselves.
I discarded this option as I wanted my changes to be portable to Cobra, Viper, PFlags if we wanted.
Checklist