Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update viper #1443

Merged
merged 4 commits into from
Dec 18, 2023
Merged

chore: update viper #1443

merged 4 commits into from
Dec 18, 2023

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Dec 18, 2023

Description

Closes #1439

Updates Viper

Also:

  • Make the binding public so that it can be tested
  • Improve test coverage for env variables (particularly repository flags)
  • Remove cycle dependency by splitting flag types.

In the end, the AutomaticEnv and the SetEnvPrefix wasn't the way to go because the values in EnvironmentVariables shouldn't used the prefixed version.
The current code is the final version which I believe is the simplest version.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski requested review from didroe and gotbadger and removed request for didroe December 18, 2023 13:26
@cfabianski cfabianski changed the title Chore/update viper chore: update viper Dec 18, 2023
@cfabianski cfabianski merged commit 11beff4 into main Dec 18, 2023
8 checks passed
@cfabianski cfabianski deleted the chore/update-viper branch December 18, 2023 13:50
@cfabianski
Copy link
Collaborator Author

This PR would be useful if we wanted to improve it spf13/viper#1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve flags testing coverage
2 participants