Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make cache work again after diff fixes #1385

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: make cache work again after diff fixes #1385

merged 1 commit into from
Nov 9, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Nov 9, 2023 •
edited
Loading

Description

Fixes the cache behaviour and adds a test to check that an uncached and cached scan of the same file match.

Since #1381, we were telling the reporting logic that there were no files in the report when using the cache (as we skip getting the file list).

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from gotbadger November 9, 2023 11:45
@didroe didroe merged commit fd6acef into main Nov 9, 2023
9 checks passed
@didroe didroe deleted the fix/caching branch November 9, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diffscan fixes cause error when using cache scan
2 participants
@didroe @gotbadger