Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show discovery process #1378

Merged
merged 2 commits into from
Nov 7, 2023
Merged

feat: show discovery process #1378

merged 2 commits into from
Nov 7, 2023

Conversation

gotbadger
Copy link
Contributor

Description

Give feedback about discovery stage of the scan

We use a spinner since we dont know how many lines we will have

Analyzing codebase
⠸  (400974/-) [0s]
Loading rules
Scanning target ../../phpbb

Related

#1356

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger requested a review from cfabianski November 6, 2023 14:47
@gotbadger gotbadger marked this pull request as ready for review November 6, 2023 15:56
@gotbadger gotbadger merged commit 996e988 into main Nov 7, 2023
8 checks passed
@gotbadger gotbadger deleted the feat/show-discovery-process branch November 7, 2023 09:29
@gotbadger gotbadger mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotbadger @cfabianski