Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit cleanly when meta is not available #1365

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: exit cleanly when meta is not available #1365

merged 1 commit into from
Oct 31, 2023

Conversation

gotbadger
Copy link
Contributor

Description

When metadata cannot be calculated and the report is invalid do not try and then upload it.

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger marked this pull request as ready for review October 31, 2023 16:20
@gotbadger gotbadger requested a review from didroe October 31, 2023 16:20
@gotbadger gotbadger merged commit 424155a into main Oct 31, 2023
8 checks passed
@gotbadger gotbadger deleted the fix/no-sha-present branch October 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault When SHA resolution fails
2 participants
@gotbadger @didroe