Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account for severity flag in fail-on-severity logic #1354

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: account for severity flag in fail-on-severity logic #1354

merged 1 commit into from
Oct 26, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Oct 26, 2023 •
edited
Loading

Description

Only treat findings as a failure if their severity is enabled (eg. with --severity). Currently, --fail-on-severity and --severity are separate, so you can skip a level with --severity but still have a failure if there is a finding with that level.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from cfabianski October 26, 2023 08:56
@didroe didroe merged commit 335b311 into main Oct 26, 2023
9 checks passed
@didroe didroe deleted the fix/fail-on-severity branch October 26, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didroe @cfabianski