fix: don't use asterisk for non-literal strings #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didroe
force-pushed
the
fix/dont-use-asterisk-for-nonliteral-strings
branch
from
a8480b9 to
60dffa1
Compare
cfabianski
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the Unicode Replacement character instead of using an asterisk
*for non-literal portions of strings. This allows rules to match any string value (eg. including asterisks) without false positives.The Object Replacement character (
U+FFFC) is more suited to this application but many fonts will render the character as whitespace, which would make it harder to understand when debugging. Therefore we use the Replacement character (U+FFFD) instead (intended for a single unknown character).Checklist