Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: java and javascript since php changes #1300

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: java and javascript since php changes #1300

merged 2 commits into from
Oct 3, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Oct 3, 2023

Description

Fixes issues relating to engine changes made for PHP support:

  • Add missing pattern container types for Java
  • Fix handling of strings for Javascript

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from cfabianski October 3, 2023 14:56
@didroe didroe merged commit d4bfbfe into main Oct 3, 2023
8 checks passed
@didroe didroe deleted the fix/add-missing-java-pattern-containers branch October 3, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didroe @cfabianski