Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php fixes from writing rules #1294

Merged
merged 13 commits into from
Oct 2, 2023
Merged

fix: php fixes from writing rules #1294

merged 13 commits into from
Oct 2, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Sep 25, 2023

Description

Fixes for PHP:

  • Make elements in associative array initializers unanchored
  • Improve usefulness of variable shape error message - this is encountered sometimes when a rule is invalid
  • Handle both single and double quoted strings in patterns - these now match both kinds of strings in the code (for literals)
  • Lookup variables in more places
  • Update pattern match node and unanchored offsets to account for fixups
  • Add more container types
  • Fix string handling (applies to other languages also)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski mentioned this pull request Sep 25, 2023
4 tasks
@cfabianski cfabianski force-pushed the fix/php-fixes branch 2 times, most recently from cc104f9 to 2425331 Compare September 27, 2023 13:23
@didroe didroe marked this pull request as ready for review October 2, 2023 08:43
@didroe didroe requested a review from cfabianski October 2, 2023 08:43
@didroe didroe merged commit 6f6e6b9 into main Oct 2, 2023
9 checks passed
@didroe didroe deleted the fix/php-fixes branch October 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants