feat: allow diffscans to be sent to bearer cloud

Bearer · Oct 4, 2023 · 9bedf73 · 9bedf73
1 parent d4bfbfe
commit 9bedf73
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/internal/commands/artifact/run.go b/internal/commands/artifact/run.go
@@ -38,7 +38,7 @@ import (
 	"github.com/bearer/bearer/internal/types"
 )
 
-var ErrFileListEmpty = errors.New("couldn't find any files to scan in the specified directory")
+var ErrFileListEmpty = errors.New("couldn't find any files to scan in the specified directory, for diff scans this can mean the compared branches were identical")
 
 // TargetKind represents what kind of artifact bearer scans
 type TargetKind string

diff --git a/internal/commands/process/settings/settings.go b/internal/commands/process/settings/settings.go
@@ -364,13 +364,9 @@ func FromOptions(opts flag.Options, versionMeta *version_check.VersionMeta) (Con
 	}
 
 	if config.Scan.DiffBaseBranch != "" {
-		if config.Report.Report != flag.ReportSecurity {
+		if config.Report.Report != flag.ReportSecurity && config.Report.Report != flag.ReportSaaS {
 			return Config{}, errors.New("diff base branch is only supported for the security report")
 		}
-
-		if config.Client != nil {
-			return Config{}, errors.New("diff base branch is not supported when using an api key")
-		}
 	}
 
 	return config, nil