fix: avoid compiling privacy report twice (#1290)

* fix: avoid compiling privacy report twice * feat: remove AddReportData call from CSV method
Bearer · Sep 27, 2023 · 6632e1d · 6632e1d
1 parent 92b2534
commit 6632e1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/report/output/privacy/privacy.go b/internal/report/output/privacy/privacy.go
@@ -68,10 +68,6 @@ const PLACEHOLDER_VALUE = "Unknown"
 func BuildCsvString(reportData *outputtypes.ReportData, config settings.Config) (*strings.Builder, error) {
 	csvStr := &strings.Builder{}
 	csvStr.WriteString("\nSubject,Data Types,Detection Count,Critical Risk Finding,High Risk Finding,Medium Risk Finding,Low Risk Finding,Rules Passed\n")
-	err := AddReportData(reportData, config)
-	if err != nil {
-		return csvStr, err
-	}
 
 	for _, subject := range reportData.PrivacyReport.Subjects {
 		subjectArr := []string{

diff --git a/internal/report/output/privacy/privacy_test.go b/internal/report/output/privacy/privacy_test.go
@@ -28,6 +28,10 @@ func TestBuildCsvString(t *testing.T) {
 	output := &outputtypes.ReportData{
 		Dataflow: dummyDataflow(),
 	}
+	err = privacy.AddReportData(output, config)
+	if err != nil {
+		t.Fatalf("failed to add privacy report:%s", err)
+	}
 	stringBuilder, _ := privacy.BuildCsvString(output, config)
 	cupaloy.SnapshotT(t, stringBuilder.String())
 }