fix(php): lookup variables in subscript indices

Bearer · Oct 10, 2023 · 28838d9 · 28838d9
1 parent 6689428
commit 28838d9
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/internal/languages/php/analyzer/analyzer.go b/internal/languages/php/analyzer/analyzer.go
@@ -47,6 +47,8 @@ func (analyzer *analyzer) Analyze(node *sitter.Node, visitChildren func() error)
 		return visitChildren()
 	case "dynamic_variable_name":
 		return analyzer.analyzeDynamicVariableName(node, visitChildren)
+	case "subscript_expression":
+		return analyzer.analyzeSubscript(node, visitChildren)
 	case "binary_expression",
 		"unary_op_expression",
 		"argument",
@@ -178,6 +180,17 @@ func (analyzer *analyzer) analyzeDynamicVariableName(node *sitter.Node, visitChi
 	return visitChildren()
 }
 
+// foo["bar"]
+func (analyzer *analyzer) analyzeSubscript(node *sitter.Node, visitChildren func() error) error {
+	object := node.NamedChild(0)
+	analyzer.builder.Dataflow(node, object)
+	analyzer.lookupVariable(object)
+
+	analyzer.lookupVariable(node.NamedChild(1))
+
+	return visitChildren()
+}
+
 // default analysis, where the children are assumed to be aliases
 func (analyzer *analyzer) analyzeGenericConstruct(node *sitter.Node, visitChildren func() error) error {
 	analyzer.builder.Alias(node, analyzer.builder.ChildrenFor(node)...)