fix(ruby): tighten sql injection patterns #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some Active Record methods that are vulnerable to SQL injection are also methods used by e.g. the Enumerable class (such as
count
,sum
). This can result in a lot of false positives from Ruby's SQLi rule.In this PR, we tighten the SQLi patterns for these shared methods. Namely,
s
)Alternate solutions considered:
count
especially) quite dangerous if exposed to SQL injectionChecklist
If this is your first time contributing please sign the CLA