fix: python rules #439
Merged
fix: python rules #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotbadger
approved these changes
Jun 3, 2024
|
Its strange because CI is just running on a project. Maybe its something to do with just being a single rule in CI? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems these kinds of issues are not picked up by our schema validator or by the bearer-rules unit tests, but rather cause null pointer issues in the engine when run on real-world repositories (which is done manually as part of the release process). We need to investigate why the unit tests for these two rules were able to pass -- seems strange that they were working 🤔
Checklist
If this is your first time contributing please sign the CLA