Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve SQLi #255

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: improve SQLi #255

merged 1 commit into from
Feb 12, 2024

Conversation

cfabianski
Copy link
Collaborator

Description

Improve test coverage for SQLi

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@cfabianski cfabianski force-pushed the feat/improve-gosec-sqli-rule branch from 9fc50cd to 9bf3c37 Compare February 12, 2024 14:17
Copy link
Collaborator

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More descriptive test file names would be good next time 😅

Probably good to get someone else's thoughts on the input change too (as this is global), but it looks okay to me ✅

@@ -0,0 +1,22 @@
// Format string with \n\r
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a repeat of test09?

@@ -26,6 +26,7 @@ auxiliary:
- os.Args
- os.Getenv()
- func $<_>($<...>$<!>$<ARG> $<_>$<...>)
- func ($<...>) $<_>($<...>$<!>$<_> $<_>$<...>)$<...>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an example of the use case for this pattern?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfabianski cfabianski merged commit 7a20965 into main Feb 12, 2024
20 checks passed
@cfabianski cfabianski deleted the feat/improve-gosec-sqli-rule branch February 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants