Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve writing rules #212

Merged
merged 7 commits into from
Jan 31, 2024
Merged

chore: improve writing rules #212

merged 7 commits into from
Jan 31, 2024

Conversation

cfabianski
Copy link
Collaborator

Description

Bootstrap the writing of a rule

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@cfabianski cfabianski force-pushed the improve-writing-of-rules branch from f51d855 to a6469a3 Compare January 31, 2024 10:59
@cfabianski cfabianski force-pushed the improve-writing-of-rules branch from a6469a3 to 1dcfa85 Compare January 31, 2024 11:04
Copy link
Collaborator

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught some mistakes from my old code, but otherwise looks good...

Thanks for this! Can't wait to write my next rule now 🙏

scripts/generate_rule.js Outdated Show resolved Hide resolved
scripts/generate_rule.js Outdated Show resolved Hide resolved
scripts/generate_rule.js Outdated Show resolved Hide resolved
scripts/generate_rule.js Outdated Show resolved Hide resolved
@cfabianski cfabianski merged commit 035d70d into main Jan 31, 2024
19 checks passed
@cfabianski cfabianski deleted the improve-writing-of-rules branch January 31, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants