Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add new evaluator #180

Merged
merged 2 commits into from
Nov 22, 2023
Merged

chore: add new evaluator #180

merged 2 commits into from
Nov 22, 2023

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Nov 17, 2023 •
edited
Loading

Description

Ref Bearer/bearer#1405

Example of how the testing could be done following this Bearer/bearer#1404

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@cfabianski cfabianski mentioned this pull request Nov 17, 2023
Merged
5 tasks
@cfabianski cfabianski marked this pull request as ready for review November 21, 2023 13:36
@cfabianski cfabianski force-pushed the spike/improve-rule-testing branch from a000282 to d17baf0 Compare November 21, 2023 15:07
@cfabianski
Copy link
Collaborator Author

Passes on canary https://github.com/Bearer/bearer-rules/actions/runs/6947074346

@cfabianski cfabianski merged commit a344660 into main Nov 22, 2023
35 checks passed
@cfabianski cfabianski deleted the spike/improve-rule-testing branch November 22, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

@gotbadger gotbadger Awaiting requested review from gotbadger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfabianski @didroe