Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unwanted semicolon in ruby datatype rule #167

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: remove unwanted semicolon in ruby datatype rule #167

merged 1 commit into from
Oct 18, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Oct 18, 2023

Description

Removes an unwanted semicolon that was causing the shared Ruby datatype rule to fail in older CLI versions.

Also removes the semicolon from the Javascript rule - this has no functional effect but is done for consistency with not using semicolons in JS rules.

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from cfabianski October 18, 2023 09:31
@didroe didroe merged commit 8d7cc27 into main Oct 18, 2023
17 checks passed
@didroe didroe deleted the fix/ruby-datatype-rule branch October 18, 2023 09:41
@cfabianski
Copy link
Collaborator

PHP 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

@cfabianski cfabianski Awaiting requested review from cfabianski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didroe @cfabianski @gotbadger