Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve jwt not revoked rules and tests #157

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: improve jwt not revoked rules and tests #157

merged 1 commit into from
Sep 19, 2023

Conversation

cfabianski
Copy link
Collaborator

Description

We were not taking into account as_expression so the scope needs to be result instead of cursor

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@cfabianski cfabianski requested a review from didroe September 19, 2023 12:52
@cfabianski cfabianski merged commit b1f7187 into main Sep 19, 2023
12 checks passed
@cfabianski cfabianski deleted the fix/jwt-secret branch September 19, 2023 13:02
@cfabianski cfabianski mentioned this pull request Sep 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe Awaiting requested review from didroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cfabianski