fix(php)(symfony): multiple parameters for SQLi sanitization method

Bearer · May 17, 2024 · d2954dc · d2954dc
1 parent eb18ecf
commit d2954dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rules/php/symfony/sql_injection.yml b/rules/php/symfony/sql_injection.yml
@@ -48,9 +48,9 @@ auxiliary:
             scope: cursor
   - id: php_symfony_sql_injection_input_sanitizer
     patterns:
-      - pattern: $<_>->createNamedParameter($<!>$<_>)
       - pattern: $<_>->quote($<!>$<_>)
-      - pattern: $<_>->setParameter($<!>$<_>)
+      - pattern: $<_>->createNamedParameter($<!>$<_>$<...>)
+      - pattern: $<_>->setParameter($<!>$<_>$<...>)
 languages:
   - php
 severity: critical

diff --git a/tests/php/symfony/sql_injection/testdata/injection-query-builder.php b/tests/php/symfony/sql_injection/testdata/injection-query-builder.php
@@ -23,11 +23,11 @@ public function oops2(): array
         $data = $query->getResult();
         return $data;
     }
-    
+
     public function okay(): array
     {
       $queryBuilder->where(
-        $queryBuilder->expr()->like('name', $queryBuilder->createNamedParameter($_GET['username'])
+        $queryBuilder->expr()->like('name', $this->queryBuilder->createNamedParameter($_GET['username'], Connection::PARAM_STR))
       );
     }
 }