ci(php): test snaps to annotations (#300)

tests/php/lang/cbc_predictable_iv/test.js

@@ -1,16 +1,30 @@
-const { createInvoker, getEnvironment } = require("../../../helper.js")
+const {
+  createNewInvoker,
+  getEnvironment,
+} = require("../../../helper.js")
 const { ruleId, ruleFile, testBase } = getEnvironment(__dirname)
 
 describe(ruleId, () => {
-  const invoke = createInvoker(ruleId, ruleFile, testBase)
+  const invoke = createNewInvoker(ruleId, ruleFile, testBase)
 
-  test("ok", () => {
-    const testCase = "ok.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
+
+    test("bad", () => {
+      const testCase = "bad.php"
 
-  test("bad", () => {
-    const testCase = "bad.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
-})
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+
+    test("ok", () => {
+      const testCase = "ok.php"
+
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+})

tests/php/lang/cbc_predictable_iv/testdata/bad.php

@@ -2,5 +2,7 @@
 
 $algorithm = "aes-256-cbc";
 
+# bearer:expected php_lang_cbc_predictable_iv
 openssl_encrypt($data, $algorithm, $passphrase, 0, "oops", null);
+# bearer:expected php_lang_cbc_predictable_iv
 openssl_encrypt($data, $algorithm, $passphrase, iv: "oops");

tests/php/lang/cookies/test.js

@@ -1,16 +1,30 @@
-const { createInvoker, getEnvironment } = require("../../../helper.js")
+const {
+  createNewInvoker,
+  getEnvironment,
+} = require("../../../helper.js")
 const { ruleId, ruleFile, testBase } = getEnvironment(__dirname)
 
 describe(ruleId, () => {
-  const invoke = createInvoker(ruleId, ruleFile, testBase)
+  const invoke = createNewInvoker(ruleId, ruleFile, testBase)
 
-  test("bad", () => {
-    const testCase = "bad.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
+
+    test("bad", () => {
+      const testCase = "bad.php"
 
-  test("ok", () => {
-    const testCase = "ok.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
-})
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+
+    test("ok", () => {
+      const testCase = "ok.php"
+
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+})

tests/php/lang/cookies/testdata/bad.php

@@ -1,4 +1,6 @@
 <?php
 
+# bearer:expected php_lang_cookies
 setcookie("user_email", $user->email, 0);
+# bearer:expected php_lang_cookies
 setrawcookie("user_email", $user->email, 0);

tests/php/lang/deserialization_of_user_input/test.js

@@ -1,16 +1,30 @@
-const { createInvoker, getEnvironment } = require("../../../helper.js")
+const {
+  createNewInvoker,
+  getEnvironment,
+} = require("../../../helper.js")
 const { ruleId, ruleFile, testBase } = getEnvironment(__dirname)
 
 describe(ruleId, () => {
-  const invoke = createInvoker(ruleId, ruleFile, testBase)
+  const invoke = createNewInvoker(ruleId, ruleFile, testBase)
 
-  test("bad", () => {
-    const testCase = "bad.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
+
+    test("bad", () => {
+      const testCase = "bad.php"
 
-  test("ok", () => {
-    const testCase = "ok.php"
-    expect(invoke(testCase)).toMatchSnapshot()
-  })
-})
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+
+    test("ok", () => {
+      const testCase = "ok.php"
+
+      const results = invoke(testCase)
+
+      expect(results.Missing).toEqual([])
+      expect(results.Extra).toEqual([])
+    })
+
+})

tests/php/lang/deserialization_of_user_input/testdata/bad.php

@@ -1,3 +1,4 @@
 <?php
 
+# bearer:expected php_lang_deserialization_of_user_input
 $data = unserialize($_GET["oops"], ["max_depth" => 10]);