fix: extract globals() to aux pattern

Bearer · May 20, 2024 · 58b87db · 58b87db
1 parent 218f303
commit 58b87db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/rules/python/lang/reflection_using_user_input.yml b/rules/python/lang/reflection_using_user_input.yml
@@ -7,8 +7,11 @@ patterns:
       - variable: USER_INPUT
         detection: python_shared_common_user_input
         scope: result
-  - pattern: globals()[$<USER_INPUT>]$<...>
+  - pattern: $<GLOBALS>[$<USER_INPUT>]$<...>
     filters:
+      - variable: GLOBALS
+        detection: python_lang_reflection_using_user_input_globals
+        scope: result
       - variable: USER_INPUT
         detection: python_shared_common_user_input
         scope: result
@@ -30,6 +33,10 @@ patterns:
       - variable: USER_INPUT
         detection: python_shared_common_user_input
         scope: result
+auxiliary:
+  - id: python_lang_reflection_using_user_input_globals
+    patterns:
+      - globals()
 languages:
   - python
 severity: high

diff --git a/tests/python/lang/reflection_using_user_input/testdata/main.py b/tests/python/lang/reflection_using_user_input/testdata/main.py
@@ -4,6 +4,10 @@ def bad(num1, num2):
 
   # bearer:expected python_lang_reflection_using_user_input
   result = globals()[operation](num1, num2)
+
+  my_globals = globals()
+  # bearer:expected python_lang_reflection_using_user_input
+  my_globals[operation](num1, num2)
 
 def bad2():
   user_action = input("what hack today? get_username or get_password")