Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i let copilot write this pr because im lazy #9

Merged
merged 5 commits into from
Oct 27, 2024

style: format code with Ktlint

24d4e91
Select commit
Loading
Failed to load commit list.
Merged

i let copilot write this pr because im lazy #9

style: format code with Ktlint
24d4e91
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / detekt succeeded Oct 27, 2024 in 6s

122 new alerts

New alerts in code changed by this pull request

  • 122 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 14 in src/main/java/frc/robot/Robot.kt

See this annotation in the file changed.

Code scanning / detekt

Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning

Class 'Robot' with '14' functions detected. Defined threshold inside classes is set to '11'

Check warning on line 15 in src/main/java/frc/robot/Robot.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 17 in src/main/java/frc/robot/Robot.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 40 in src/main/java/frc/robot/Robot.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 29 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 31 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 31 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 48 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 49 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 85 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 102 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 104 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 105 in src/main/java/frc/robot/RobotContainer.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 9 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

edu.wpi.first.networktables.* is a wildcard import. Replace it with fully qualified imports.

Check warning on line 22 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Constructor parameter names should follow the naming convention set in the projects configuration. Warning

Constructor private parameter names should match the pattern: [a-z][A-Za-z0-9]*

Check warning on line 42 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 46 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 54 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Private variable names should match the pattern: (_)?[a-z][A-Za-z0-9]*

Check warning on line 55 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 55 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 55 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 56 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 56 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 56 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 57 in src/main/java/frc/robot/Telemetry.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.