Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more phase diagram fixes #53

Merged
merged 4 commits into from
Aug 16, 2022
Merged

more phase diagram fixes #53

merged 4 commits into from
Aug 16, 2022

Conversation

rkurchin
Copy link
Member

@rkurchin rkurchin commented Aug 16, 2022

  • improve guessing by shifting by the previous delta instead of just reusing the result
  • make tolerance for end of phase diagram a function argument
  • figure out why I sometimes get T not defined error for find_phase_boundaries if I don't explicitly pass a temperature?
  • maybe add some of the test coverage from better test coverage #45 ?

…osure of phase diagram a function argument

Signed-off-by: Rachel Kurchin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #53 (0efffc2) into main (ef8ed9a) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   53.08%   52.64%   -0.45%     
==========================================
  Files          14       14              
  Lines         356      359       +3     
==========================================
  Hits          189      189              
- Misses        167      170       +3     
Impacted Files Coverage Δ
src/phase_diagrams.jl 60.00% <0.00%> (-3.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Rachel Kurchin <[email protected]>
@rkurchin rkurchin merged commit f73d38a into main Aug 16, 2022
@rkurchin rkurchin deleted the pb_patch branch August 16, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants