Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better test coverage #45

Open
rkurchin opened this issue Jul 26, 2022 · 0 comments
Open

better test coverage #45

rkurchin opened this issue Jul 26, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rkurchin
Copy link
Member

Coverage isn't terrible, but there are some particular corners that are currently left by the wayside...

Particularly (in roughly decreasing order of importance as I see it):

  • phase_diagram for different model types, different parameter values, deintercalation case
  • quantum capacitance functionality
  • integrand function
  • model fitting
  • is there a good way to test plotting functions?

Leaving this here as a note for the future if I (or any contributors...?) want to address it...
@rkurchin rkurchin added the good first issue Good for newcomers label Jul 26, 2022
@rkurchin rkurchin mentioned this issue Aug 16, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rkurchin