Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fufeck feat page partenaire #1732

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Fufeck feat page partenaire #1732

merged 4 commits into from
Jun 24, 2024

Conversation

fufeck
Copy link
Contributor

@fufeck fufeck commented Apr 24, 2024 •
edited
Loading

Page partneaire

Capture d’écran 2024-06-05 à 16 52 54 Capture d’écran 2024-06-05 à 16 53 03 Capture d’écran 2024-06-05 à 16 53 14 Capture d’écran 2024-06-05 à 16 53 22

@fufeck fufeck marked this pull request as draft April 24, 2024 11:59
@FrederiqWilliams
Copy link
Member

attention dans le texte des pages en exemple, corriger moissonneur et moissonnage avec 2 "n"

@fufeck fufeck mentioned this pull request Jun 5, 2024
Merged
@fufeck fufeck requested a review from MaGOs92 June 5, 2024 15:38
@fufeck fufeck marked this pull request as ready for review June 5, 2024 15:46
@MaGOs92
Copy link
Contributor

MaGOs92 commented Jun 6, 2024

Tests :

  • Y'a un petit souci avec le tooltip :
Capture d’écran 2024-06-06 à 16 36 21
  • J'ai pas compris comment on pouvait accéder à la fiche partenaire pour les organisations et les entreprises. Pour les communes c'est OK. A mon avis il faudrait ajouter un lien dans cette carte :
Capture d’écran 2024-06-06 à 16 44 36

MaGOs92
MaGOs92 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

components/bases-locales/charte/commune.js Outdated Show resolved Hide resolved
components/bases-locales/charte/partenaires/moissonneur-bal/revisions/revision-item.js Show resolved Hide resolved
lib/moissonneur-bal.js Show resolved Hide resolved
@MaGOs92
Copy link
Contributor

MaGOs92 commented Jun 6, 2024

Apparement il manque une props dans le :
Capture d’écran 2024-06-06 à 17 06 42

@fufeck fufeck force-pushed the fufeck_feat_page-partenaire branch from 364a72b to f11d11d Compare June 11, 2024 07:52
@fufeck fufeck requested review from antoineludeau and nkokla June 11, 2024 07:54
@fufeck fufeck force-pushed the fufeck_feat_page-partenaire branch from f11d11d to e3c1c5c Compare June 11, 2024 12:30
@fufeck fufeck merged commit 4d4098d into master Jun 24, 2024
2 checks passed
@fufeck fufeck deleted the fufeck_feat_page-partenaire branch June 24, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaGOs92 MaGOs92 MaGOs92 approved these changes

@antoineludeau antoineludeau Awaiting requested review from antoineludeau

@nkokla nkokla Awaiting requested review from nkokla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fufeck @FrederiqWilliams @MaGOs92