Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page stats dependencies #1690

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

antoineludeau
Copy link
Member

Context

Currently on adresse.data.gouv, if there is an issue with ban-plateforme API, some pages, the home page included, will display an error message (error 404 or error 500)

Enhancement

This PR aims to withdraw the stats dependencies on :

  • the "Home" page
  • the "Programme Bal" page

Before :

Home page & Programme Bal page :
Capture d’écran 2024-01-12 à 16 20 28

After :

Home Page :
Capture d’écran 2024-01-12 à 16 32 21


Capture d’écran 2024-01-12 à 16 32 33

Programme Bal :
Capture d’écran 2024-01-12 à 16 19 40


Capture d’écran 2024-01-12 à 16 33 16

lib/api-ban.js Outdated Show resolved Hide resolved
@antoineludeau antoineludeau self-assigned this Jan 18, 2024
@antoineludeau antoineludeau force-pushed the antoineludeau/fix-home-page-stats-dependencies branch from 9404ee5 to 396cd35 Compare January 23, 2024 09:06
@MaGOs92 MaGOs92 self-requested a review January 23, 2024 12:55
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoineludeau antoineludeau force-pushed the antoineludeau/fix-home-page-stats-dependencies branch from 396cd35 to 558c72e Compare January 23, 2024 13:52
@antoineludeau antoineludeau merged commit 600889a into master Jan 24, 2024
1 check passed
@antoineludeau antoineludeau deleted the antoineludeau/fix-home-page-stats-dependencies branch February 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants