Add Temporal support

[xepozz]

[#48] Added https://github.com/temporalio/sdk-php support.

If you want also tests I can add them a bit later or you can do it yourself 😉 .
Now I want to discuss about solution in general.

You can see how it works in https://github.com/xepozz/symfony-temporal-demo.

[Baldinof]

Hi!

Thank you for the great work, and sorry for the late review!

I like the autoconfiguration of workflows / activities :)

[Baldinof]

Doing that forces the DIC to resolve the 2 workers but only one is used (and Temporal might even be not installed).

It's the kind of place where we could inject the container and use return $container->get(HttpWorkerInferface::class) so the service is created only if needed.

[xepozz]

I've marked them with lazy()

[Baldinof]

Marking them lazy force the users to install symfony/proxy-manager-bridge.

If you feel incomfortable injecting the whole container, maybe we could use a service locator to inject a scoped container, what do you think?

[xepozz]

I don't like service locator. As you can see :)

What do you think if I add supports($mode): bool method into workers and configure resolver to get array of workers and pass the conditions below into them?
It will look like the following:

TemporalWorker:
supports($mode):
$mode === 'temporal'


HttpWorker:
supports($mode):
$mode === 'http'

And this resolver will look:

class WorkerResolver
{
  function __construct(iterable $workers){}

  function resolve($mode) { 
    foreach($this->workers as $worker)) {
       if($worker->supports($mode){
         return $worker;
       }
    throw new Exception();
}

WorkerResolver will be configured in the container with a tag and !tagged_iterator.

[Baldinof]

If you do this, the DIC may still instantiate the 2 workers but only one is useful, I think a locator is the best way, it's precisily why service locators exists, in the Symfony doc:

Sometimes, a service needs access to several other services without being sure that all of them will actually be used

[xepozz]

Hi, I will look at your comments at the weekends or a bit later.

[xepozz]

@Baldinof I've resolved your comments. Can you please review again?
Also I have an idea how to configure workers are creating in https://github.com/xepozz/roadrunner-bundle/blob/a239d1e6c05dbd78564dcdd72d55ad87d7f78f9a/src/Worker/TemporalWorker.php#L41-L41
We can use usual config file to configure:

1. Amount of workers
2. Their options (https://github.com/temporalio/sdk-php/blob/master/src/Worker/WorkerOptions.php#L23)

Like this format:

temporal_workers:
  first_worker: 
    option1: value1
    option2: value2:
  second_worker: 
    option1: value3
    option2: value4

This settings will be converted and used in the factory that mentioned above.
I will create issue later if we finish this PR.

[xepozz]

@Baldinof can you have a look?

[Baldinof]

Yes! Sorry for being late, I will try to have a look by the end of this week!

[Baldinof]

Marking them lazy force the users to install symfony/proxy-manager-bridge.

If you feel incomfortable injecting the whole container, maybe we could use a service locator to inject a scoped container, what do you think?

[Baldinof]

This should be in services.php

[Baldinof]

This should also be used in Baldinof\RoadRunnerBundle\Runtime\Runner

[rmikalkenas]

@Baldinof @xepozz any plans to finalize this PR and add temporal support?

[xepozz]

@rmikalkenas if you mind you may finalize this PR by yourself. I lost all context of this PR and don't have time to reproduce all scenarios

[praswicaksono]

@xepozz @Baldinof I take over this integration please review to new PR: #147 any review will be appreciated