feat: conditionally run pipelines in debug mode #223
Conversation
| if priority not in valid_priorities: | ||
| raise ValueError(f"priority must be one of {', '.join(valid_priorities)}") |
There was a problem hiding this comment.
Not need to check with the new Typing
openhexa/sdk/pipelines/runtime.py
Outdated
| @@ -50,7 +50,7 @@ def download_pipeline(url: str, token: str, run_id: str, target_dir: str): | |||
| pipelineRun(id: $id) { | |||
| id | |||
| version { | |||
| number | |||
There was a problem hiding this comment.
Issue also solved in #221 but not yet merged
| @@ -67,6 +67,7 @@ include-package-data = true | |||
| [tool.ruff] | |||
| line-length = 120 | |||
| ignore = ["E501"] | |||
| per-file-ignores = { "tests/**/test_*.py" = ["D100","D101","D102", "D103"] } # Ignore missing docstrings in tests | |||
There was a problem hiding this comment.
A preference but I am ok spending more time to provide some docstrings if we think it's valuable
| @@ -67,6 +67,7 @@ include-package-data = true | |||
| [tool.ruff] | |||
| line-length = 120 | |||
| ignore = ["E501"] | |||
| per-file-ignores = { "tests/**/test_*.py" = ["D100","D101","D102", "D103"] } # Ignore missing docstrings in tests | |||
I agree it looks odd but that's what we used in the GraphQL layer and it is also stored in the db ( So I decided to avoid complex renames and keep the same name. I can :
Option 3 might be a good one, but let's agree @qgerome |
Let's go for option 3 then :) |
qgerome
deleted the
HEXA-1076-implement-a-way-to-run-pipelines-in-debug-mode
branch
We want to provide a way for users to decide if they want to generate debug messages for the pipeline run. By default they will not be stored and shown.
Changes
log_levelsettings from the environment and decide based on that if logs should be storedHow/what to test
Screenshots / screencast
screen-capture.3.webm
Related PRs