feat: HEXA-1146 Propagate pipeline default parameters in new versions #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarfil
approved these changes
Dec 23, 2024
nazarfil
reviewed
Dec 23, 2024
hexa/pipelines/models.py
Outdated
| previous_config_from_common_parameter = {} | ||
| if self.last_version: | ||
| previous_parameters = self.last_version.parameters | ||
| common_parameters = [ |
There was a problem hiding this comment.
I have only one comment on the naming, that "common" might not reflect the best that we are talking about overlapping/shared parameters between new and previous versions
There was a problem hiding this comment.
Makes a lot of sense, thanks, fixed in next commits
nazarfil
approved these changes
Dec 24, 2024
nazarfil
deleted the
HEXA-1146-propagate-pipeline-default-parameters-with-new-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading a new pipeline version was overriding config values. This PR is about keeping the previous config values while taking into account parameters that can change.
Changes
How/what to test