Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HEXA-1120 template pipelines and template versions models + endpoint to create template #874

Merged
merged 56 commits into from
Dec 20, 2024
Merged

feat: HEXA-1120 template pipelines and template versions models + endpoint to create template #874

merged 56 commits into from
Dec 20, 2024

Conversation

YolanFery
Copy link
Contributor

@YolanFery YolanFery commented Dec 12, 2024 •
edited
Loading

Introduce models for PipelineTemplate and PipelineTemplate versions
Create a first endpoint to create a PipelineTemplate from a Pipeline

Changes

  • New PipelineTemplate and PipelineTemplateVersion
  • First version of the GraphQL Schema
  • Add get_or_create_template to the Pipeline model
  • Unit tests for the new models and method
  • Integ test for the GraphQL Schema
  • Register PipelineTemplateVersion and PipelineTemplate in the admin panel

How/what to test

This is laying foundations for the Template Pipeline feature and should have no impact on the rest

nazarfil
nazarfil reviewed Dec 16, 2024
View reviewed changes
hexa/pipelines/models.py Outdated Show resolved Hide resolved
hexa/template_pipelines/graphql/schema.graphql Outdated Show resolved Hide resolved
qgerome
qgerome reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template is IMO too broad and may lead to confusion later when we want to templates for another object.

I'd advice to prefix it by Pipeline to avoid clashes in the future. WDYT?

hexa/template_pipelines/graphql/schema.graphql Outdated Show resolved Hide resolved
@YolanFery YolanFery requested a review from qgerome December 17, 2024 12:23
qgerome
qgerome reviewed Dec 17, 2024
View reviewed changes
hexa/pipeline_templates/schema/mutations.py Outdated Show resolved Hide resolved
hexa/pipeline_templates/schema/mutations.py Outdated Show resolved Hide resolved
hexa/pipeline_templates/models.py Outdated Show resolved Hide resolved
hexa/pipeline_templates/models.py Show resolved Hide resolved
YolanFery and others added 4 commits December 20, 2024 08:27
@YolanFery @qgerome
Update hexa/pipeline_templates/schema/mutations.py
47e89d9 
Co-authored-by: Quentin Gérôme <[email protected]>
@YolanFery
Fix error permission
06c146e
@YolanFery
Fix schema
3fadf61
@YolanFery
Merge branch 'HEXA-1120-template-pipelines-template-and-template-vers…
4706bd6 
…ions-models' of github.com:BLSQ/openhexa-app into HEXA-1120-template-pipelines-template-and-template-versions-models
@YolanFery YolanFery requested a review from nazarfil December 20, 2024 07:50
@nazarfil nazarfil merged commit 22ed895 into main Dec 20, 2024
4 checks passed
@nazarfil nazarfil deleted the HEXA-1120-template-pipelines-template-and-template-versions-models branch December 20, 2024 10:54
@qgerome qgerome mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qgerome qgerome qgerome left review comments

@nazarfil nazarfil nazarfil approved these changes

@cheikhgwane cheikhgwane Awaiting requested review from cheikhgwane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YolanFery @qgerome @nazarfil