fix(CORS): Allow objects to be uploaded & download from everywhere

BLSQ · Jul 11, 2024 · eeafebc · eeafebc
1 parent 526c35f
commit eeafebc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 46 deletions.
diff --git a/hexa/files/gcp.py b/hexa/files/gcp.py
@@ -131,21 +131,7 @@ def create_bucket(self, bucket_name: str, labels: dict = None, *args, **kwargs):
 
             bucket.labels = labels
 
-            bucket.cors = [
-                {
-                    "origin": settings.CORS_ALLOWED_ORIGINS,
-                    "responseHeader": [
-                        "Authorization",
-                        "Content-Range",
-                        "Accept",
-                        "Content-Type",
-                        "Origin",
-                        "Range",
-                    ],
-                    "method": ["GET", "PUT"],
-                    "maxAgeSeconds": 3600,
-                }
-            ]
+            bucket.cors = []
             bucket.patch()
 
             return bucket

diff --git a/hexa/files/s3.py b/hexa/files/s3.py
@@ -117,37 +117,6 @@ def create_bucket(self, bucket_name: str, *args, **kwargs):
                 Bucket=bucket_name,
                 CreateBucketConfiguration={"LocationConstraint": default_region},
             )
-
-            # Define the configuration rules
-            cors_configuration = {
-                "CORSRules": [
-                    {
-                        "AllowedHeaders": [
-                            "Authorization",
-                            "Content-Range",
-                            "Accept",
-                            "Content-Type",
-                            "Origin",
-                            "Range",
-                        ],
-                        "AllowedMethods": ["GET", "PUT"],
-                        "AllowedOrigins": settings.CORS_ALLOWED_ORIGINS,
-                        "ExposeHeaders": [
-                            "ETag",
-                            "x-amz-request-id",
-                            "Authorization",
-                            "Content-Range",
-                            "Accept",
-                            "Content-Type",
-                            "Origin",
-                            "Range",
-                        ],
-                        "MaxAgeSeconds": 3000,
-                    }
-                ]
-            }
-
-            s3.put_bucket_cors(Bucket=bucket_name, CORSConfiguration=cors_configuration)
             return S3BucketWrapper(bucket_name)
         except s3.exceptions.ClientError as exc:
             # https://github.com/VeemsHQ/veems/blob/3e2e75c3407bc1f98395fe94c0e03367a82852c9/veems/media/upload_manager.py#L51C1-L51C1