fix: silent email address trim

BLSQ · Nov 14, 2024 · 3d7cc23 · 3d7cc23
1 parent 316e491
commit 3d7cc23
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/config/graphql/schema.graphql b/config/graphql/schema.graphql
@@ -6,5 +6,6 @@ scalar UUID
 scalar Generic
 scalar BigInt
 scalar OpaqueID
+scalar TrimmedString
 type Query
 type Mutation
diff --git a/config/schema.py b/config/schema.py
@@ -35,7 +35,7 @@
 
 uuid_scalar = ScalarType("UUID")
 opaque_id_scalar = ScalarType("OpaqueID")
-
+trimmed_string_scalar = ScalarType("TrimmedString")
 
 @uuid_scalar.value_parser
 def parse_uuid_value(value):
@@ -69,6 +69,14 @@ def serialize_opaque_id(value):
     return base64.b64encode(value.encode("utf-8")).decode("utf-8")
 
 
+@trimmed_string_scalar.value_parser
+def parse_trimmed_string(value):
+    try:
+        return value.strip()
+    except (ValueError, TypeError):
+        raise ValueError(f'"{value}" is not a valid string')
+
+
 type_defs = load_schema_from_path(
     f"{pathlib.Path(__file__).parent.resolve()}/graphql/schema.graphql"
 )
@@ -94,6 +102,7 @@ def serialize_opaque_id(value):
     [
         uuid_scalar,
         opaque_id_scalar,
+        trimmed_string_scalar,
         *pipelines_bindables,
         *identity_bindables,
         *tags_bindables,

diff --git a/hexa/user_management/graphql/schema.graphql b/hexa/user_management/graphql/schema.graphql
@@ -110,7 +110,7 @@ input LoginInput {
     """
     The email address of the user.
     """
-    email: String!
+    email: TrimmedString
 
     """
     The password of the user.

diff --git a/hexa/user_management/schema.py b/hexa/user_management/schema.py
@@ -297,7 +297,6 @@ def resolve_delete_team(_, info, **kwargs):
 def resolve_login(_, info, **kwargs):
     request: HttpRequest = info.context["request"]
     mutation_input = kwargs["input"]
-
     user_candidate = authenticate(
         request, email=mutation_input["email"], password=mutation_input["password"]
     )