Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-1676: prevent fetching of instances table data when on map tab #1894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Dec 23, 2024

When switching tabs on instances pages, table data would be fetched when on map tab

Related JIRA tickets : IA-1676

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Disable "list" query when tab not active

Notes

This may break cypress

How to test

Go to instances page, switch between tabs and check the network calls

Print screen / video

Screen.Recording.2024-12-23.at.12.38.55.mov

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant