Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fluviewer log & error copying approach #24

Merged
merged 6 commits into from
Jul 15, 2024
Merged

fix fluviewer log & error copying approach #24

merged 6 commits into from
Jul 15, 2024

Conversation

jpalmer37
Copy link
Collaborator

@jpalmer37 jpalmer37 commented Jul 11, 2024 •
edited
Loading

Fixes: #13

@jpalmer37 jpalmer37 mentioned this pull request Jul 11, 2024
Closed
@jpalmer37
Copy link
Collaborator Author

Here's the new code structure:

  • SAVE_LOGS function will always run and rename appropriate logs / files in the logs folder of the work-dir
  • SAFE_EXIT function will only run upon non-zero fluviewer error status and forcefully copy the fluviewer*txt files under log to the outdir
  • under exit code 0, publishDir will capture the fluviewer*txt files

@jpalmer37 jpalmer37 requested a review from dfornika July 11, 2024 20:08
dfornika
dfornika previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@dfornika dfornika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have the one optional suggestion. Let me know if you'd like to change that or just merge as-is. I'm approving either way.

modules/fluviewer.nf Outdated Show resolved Hide resolved
@dfornika dfornika self-requested a review July 15, 2024 23:06
dfornika
dfornika approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@dfornika dfornika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dfornika dfornika merged commit 2487352 into main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfornika dfornika dfornika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix output file handling in fluviewer process
2 participants
@jpalmer37 @dfornika