-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chunking / padding in more jitted functions #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python Benchmark
Benchmark suite | Current: e2f4c94 | Previous: 33c6481 | Ratio |
---|---|---|---|
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
409.89851030072197 iter/sec (stddev: 0.0000917474512014471 ) |
448.97372769084376 iter/sec (stddev: 0.00010768252729008168 ) |
1.10 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
287.34094744611156 iter/sec (stddev: 0.00019592138632801236 ) |
317.908639288445 iter/sec (stddev: 0.00016324339517406161 ) |
1.11 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
314.11748911163636 iter/sec (stddev: 0.00017371432177207754 ) |
311.7267034665557 iter/sec (stddev: 0.000157961574644504 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
425.53853402269533 iter/sec (stddev: 0.000032668243132183263 ) |
460.9773452528832 iter/sec (stddev: 0.0000280302382699016 ) |
1.08 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
302.1998207220138 iter/sec (stddev: 0.00007823281435381045 ) |
325.90509599087324 iter/sec (stddev: 0.00002651767303218152 ) |
1.08 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[1-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
327.34057544371495 iter/sec (stddev: 0.0000390685899477982 ) |
319.61514291027817 iter/sec (stddev: 0.00008675076307141969 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
435.7923311382538 iter/sec (stddev: 0.000031200257833405125 ) |
420.79011170218405 iter/sec (stddev: 0.000056588455977040354 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
274.2471369175126 iter/sec (stddev: 0.000024295624843483578 ) |
264.8027799194795 iter/sec (stddev: 0.0001529317137323866 ) |
0.97 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
264.8697338883472 iter/sec (stddev: 0.0001894896218730233 ) |
258.78998292353276 iter/sec (stddev: 0.0001316624062172319 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
435.7169119284767 iter/sec (stddev: 0.00004286455027570301 ) |
430.4672728382627 iter/sec (stddev: 0.00005864831970187205 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
272.35788364320763 iter/sec (stddev: 0.00004847655179868765 ) |
265.90373996574397 iter/sec (stddev: 0.00008542014831502879 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[50-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
268.77675991514246 iter/sec (stddev: 0.00005371927733274028 ) |
265.791128113913 iter/sec (stddev: 0.00007405533830977831 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=SphericalCoordinates,] |
396.8787192973597 iter/sec (stddev: 0.00006933889803266748 ) |
418.4270590416077 iter/sec (stddev: 0.000060773979630717 ) |
1.05 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=KeplerianCoordinates,] |
231.0397886807643 iter/sec (stddev: 0.0000695439744836481 ) |
231.08748801221205 iter/sec (stddev: 0.00014448936701770814 ) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=equatorial,-to=CometaryCoordinates,] |
232.31268767388386 iter/sec (stddev: 0.0001778946476724732 ) |
227.9358860116381 iter/sec (stddev: 0.00013859590221537891 ) |
0.98 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=SphericalCoordinates,] |
397.1937060409167 iter/sec (stddev: 0.000025784301719908212 ) |
403.3507967551499 iter/sec (stddev: 0.00019267477672370976 ) |
1.02 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=KeplerianCoordinates,] |
229.9349281356375 iter/sec (stddev: 0.00004639021762976898 ) |
232.03257691608312 iter/sec (stddev: 0.00014081508835490832 ) |
1.01 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_transform_cartesian_coordinates[100-origin=SUN,-frame=ecliptic,-to=CometaryCoordinates,] |
229.9585694586331 iter/sec (stddev: 0.00031654836003761316 ) |
228.71608696794226 iter/sec (stddev: 0.0002098589612407147 ) |
0.99 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_to_matrix |
605.2100883421627 iter/sec (stddev: 0.00002801585939576879 ) |
607.9541274088939 iter/sec (stddev: 0.00001914895923295299 ) |
1.00 |
src/adam_core/coordinates/tests/test_benchmarks.py::test_benchmark_CoordinateCovariances_from_matrix |
10876.626768511327 iter/sec (stddev: 0.000005716524211349154 ) |
10833.442722239739 iter/sec (stddev: 0.000006098802073414717 ) |
1.00 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body |
45105.999090713834 iter/sec (stddev: 0.000008553648933707666 ) |
44085.231434791414 iter/sec (stddev: 0.000011799849321268197 ) |
0.98 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark__propagate_2body_vmap |
34442.547371853325 iter/sec (stddev: 0.000010269922148659393 ) |
34571.6571958508 iter/sec (stddev: 0.000010373871263414265 ) |
1.00 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body |
362.5735616423524 iter/sec (stddev: 0.00013249307878319104 ) |
354.8027052144845 iter/sec (stddev: 0.00011698110081537731 ) |
0.98 |
src/adam_core/dynamics/tests/test_propagation.py::test_benchmark_propagate_2body_matrix |
4.492974209078201 iter/sec (stddev: 0.0006611294722280145 ) |
4.556218358663876 iter/sec (stddev: 0.0016754926108807876 ) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=1,] |
555.5723867841527 iter/sec (stddev: 0.00004642830337364369 ) |
545.9870326034594 iter/sec (stddev: 0.00003428522147781853 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=X05,-times=10000,] |
4.5254612059525465 iter/sec (stddev: 0.002501755926679824 ) |
4.57485534408067 iter/sec (stddev: 0.0008725935546845609 ) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=1,] |
1158.4145358704702 iter/sec (stddev: 0.00004110962212627991 ) |
1125.3808273878396 iter/sec (stddev: 0.00001715278074359668 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=equatorial,-code=500,-times=10000,] |
16.014191135615718 iter/sec (stddev: 0.00023859126283193687 ) |
16.168164055747425 iter/sec (stddev: 0.0006197434846977861 ) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=1,] |
569.5712406325716 iter/sec (stddev: 0.000029524642337389283 ) |
550.302329290012 iter/sec (stddev: 0.00006602006640656422 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=X05,-times=10000,] |
4.54837838780331 iter/sec (stddev: 0.000608223371277356 ) |
4.559018770195344 iter/sec (stddev: 0.0004545180366561233 ) |
1.00 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=1,] |
1178.954674117341 iter/sec (stddev: 0.00001726006689885848 ) |
1123.8304820345447 iter/sec (stddev: 0.000019482152764880997 ) |
0.95 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SUN,-frame=ecliptic,-code=500,-times=10000,] |
15.905086229517622 iter/sec (stddev: 0.001305884308323641 ) |
16.03060895695621 iter/sec (stddev: 0.0001390388394307792 ) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=1,] |
577.6254905522893 iter/sec (stddev: 0.00002518137292824378 ) |
555.6906281848661 iter/sec (stddev: 0.00002289349228814081 ) |
0.96 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=X05,-times=10000,] |
4.564139647713783 iter/sec (stddev: 0.0009376250772560163 ) |
4.557696588929683 iter/sec (stddev: 0.0020308599163969244 ) |
1.00 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=1,] |
1170.7232891352667 iter/sec (stddev: 0.000036196115176638115 ) |
1135.3448691159183 iter/sec (stddev: 0.000029771949537802526 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-code=500,-times=10000,] |
16.21574555742365 iter/sec (stddev: 0.00028095481285960594 ) |
16.44123291115134 iter/sec (stddev: 0.0001339094510924968 ) |
1.01 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=1,] |
568.7109088612988 iter/sec (stddev: 0.00007688841213043938 ) |
555.5165742935689 iter/sec (stddev: 0.00006672484374202855 ) |
0.98 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=X05,-times=10000,] |
4.536938192781036 iter/sec (stddev: 0.0022254874702639653 ) |
4.510950815777158 iter/sec (stddev: 0.00561533211068905 ) |
0.99 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=1,] |
1172.1052286838562 iter/sec (stddev: 0.00001874954598755323 ) |
1136.5008166125244 iter/sec (stddev: 0.00003602258035093429 ) |
0.97 |
src/adam_core/observers/tests/test_benchmarks.py::test_benchmark_get_observer_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-code=500,-times=10000,] |
16.11386441813921 iter/sec (stddev: 0.0012776278248283323 ) |
16.320742685189092 iter/sec (stddev: 0.00017396045889890447 ) |
1.01 |
src/adam_core/orbits/tests/test_benchmarks.py::test_benchmark_iterate_real_orbits |
16993.392801796737 iter/sec (stddev: 0.0000025953527879358152 ) |
17111.308913204968 iter/sec (stddev: 0.000001959875262483035 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=1,] |
1397.2526608647709 iter/sec (stddev: 0.00003940136772361413 ) |
1366.9360904779494 iter/sec (stddev: 0.000023985934942488515 ) |
0.98 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=EARTH,-times=10000,] |
16.066609366845114 iter/sec (stddev: 0.0001773511008412831 ) |
16.25974361190578 iter/sec (stddev: 0.00022897851461380373 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=1,] |
1430.7846238067184 iter/sec (stddev: 0.000023848951096177963 ) |
1388.8875028813648 iter/sec (stddev: 0.00002145470157312129 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SUN,-times=10000,] |
17.42249647451297 iter/sec (stddev: 0.0012909620217428485 ) |
17.79121530258849 iter/sec (stddev: 0.00030145727299219285 ) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1420.5280917726545 iter/sec (stddev: 0.000017057731644221316 ) |
1382.4406178913403 iter/sec (stddev: 0.000031583598375734174 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
16.670083805041664 iter/sec (stddev: 0.0012542994351410805 ) |
17.022915550974833 iter/sec (stddev: 0.00020678584933981898 ) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1425.4926512402935 iter/sec (stddev: 0.000018129033545828667 ) |
1381.468730092529 iter/sec (stddev: 0.00001700928064954726 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
15.913707143243174 iter/sec (stddev: 0.0009366367873121088 ) |
16.135281572027214 iter/sec (stddev: 0.00024727649726322576 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=1,] |
1441.179677153106 iter/sec (stddev: 0.000017058432897314636 ) |
1392.1930305122835 iter/sec (stddev: 0.00001651141319186247 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SUN,-times=10000,] |
17.47153402030485 iter/sec (stddev: 0.0013506211510830623 ) |
17.740834072164855 iter/sec (stddev: 0.0011812218784890895 ) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1422.2277030434473 iter/sec (stddev: 0.00005882462021291334 ) |
1376.2143914561318 iter/sec (stddev: 0.000018975253016070843 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SUN,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
16.640352249868336 iter/sec (stddev: 0.0007914751851516913 ) |
16.795074644795157 iter/sec (stddev: 0.0011727263199972817 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=1,] |
1425.823214259895 iter/sec (stddev: 0.000019565550339691784 ) |
1385.1962837244048 iter/sec (stddev: 0.000015981945103873334 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=EARTH,-times=10000,] |
16.32141304787933 iter/sec (stddev: 0.000161233986307688 ) |
16.413111957040922 iter/sec (stddev: 0.001156466960726552 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=1,] |
1429.0485000647363 iter/sec (stddev: 0.00003288992385410286 ) |
1388.7627225884094 iter/sec (stddev: 0.000015855139109197414 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SUN,-times=10000,] |
16.611846611969362 iter/sec (stddev: 0.001118240786772149 ) |
16.953169091248004 iter/sec (stddev: 0.00026016581701237396 ) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1430.0780337306735 iter/sec (stddev: 0.00003959769743413016 ) |
1391.4577565018853 iter/sec (stddev: 0.00001736658446653196 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=equatorial,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
17.583059623869133 iter/sec (stddev: 0.0002176055030777598 ) |
17.793629238977292 iter/sec (stddev: 0.00024258433161370696 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=1,] |
1424.8852433671289 iter/sec (stddev: 0.0000175271527291812 ) |
1380.3603624682935 iter/sec (stddev: 0.00001743017020416356 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=EARTH,-times=10000,] |
16.16169230882761 iter/sec (stddev: 0.0012227898765124535 ) |
16.276983568057485 iter/sec (stddev: 0.00013270522759101079 ) |
1.01 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=1,] |
1443.9274963155285 iter/sec (stddev: 0.00001755247110144182 ) |
1381.0587918765216 iter/sec (stddev: 0.000021832055861591595 ) |
0.96 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SUN,-times=10000,] |
16.552335047349224 iter/sec (stddev: 0.0013584548421572793 ) |
16.80892383551406 iter/sec (stddev: 0.00023038159544932108 ) |
1.02 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=1,] |
1444.123257387403 iter/sec (stddev: 0.000039427907958322636 ) |
1399.441418634932 iter/sec (stddev: 0.000016529287983634414 ) |
0.97 |
src/adam_core/utils/tests/test_benchmarks.py::test_benchmark_get_perturber_state[origin=SOLAR_SYSTEM_BARYCENTER,-frame=ecliptic,-perturber=SOLAR_SYSTEM_BARYCENTER,-times=10000,] |
17.47434600243287 iter/sec (stddev: 0.0009827038107524243 ) |
17.768378787997666 iter/sec (stddev: 0.00016381972673168462 ) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
akoumjian
force-pushed
the
ak/more-speed
branch
from
December 6, 2024 02:44
f9ab7ab
to
e2f4c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.