Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/shared design and splash #45

Merged
merged 14 commits into from
Mar 15, 2024
Merged

UI/shared design and splash #45

merged 14 commits into from
Mar 15, 2024

Conversation

PHPLukaas
Copy link
Member

@PHPLukaas PHPLukaas commented Mar 15, 2024

Closes #40

  • Adding application icons
  • Lots of refactoring and architecture changes
  • Adaptation of the AppBar to make it generic
  • Added logout page
  • A bit of design, mutualization of styles etc.

# Conflicts:
#	frontend/app_student/lib/profils/views/profil_page.dart
#	frontend/app_student/lib/week_schedule/views/week_schedule.dart
#	frontend/app_student/lib/week_schedule/views/widgets/components/app_bar_week_schedule.dart
- ♻️ Refactor of class page
- Added translations
# Conflicts:
#	frontend/app_student/lib/l10n/app_fr.arb
#	frontend/app_student/lib/profils/views/profil.dart
#	frontend/app_student/lib/routes.dart
@PHPLukaas PHPLukaas requested a review from julesartd March 15, 2024 18:19
@PHPLukaas PHPLukaas self-assigned this Mar 15, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, we should also do this for TextStyle to standardise fonts

Copy link
Collaborator

@julesartd julesartd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great pull request, the codebase is on the right track

@julesartd julesartd merged commit 9148d9a into dev Mar 15, 2024
1 check passed
@PHPLukaas PHPLukaas deleted the ui/shared-design-and-splash branch April 2, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Share common design elements
2 participants