Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️: l10n and add route profil page #44

Merged
merged 8 commits into from
Mar 15, 2024
Merged

♻️: l10n and add route profil page #44

merged 8 commits into from
Mar 15, 2024

Conversation

Yuta1409
Copy link
Collaborator

@Yuta1409 Yuta1409 commented Mar 15, 2024 •
edited
Loading

Close #39

  • Add a variable for the message in the profile page
  • Redirect to the classes page with the

@Yuta1409 Yuta1409 requested a review from PHPLukaas March 15, 2024 13:46
@Yuta1409 Yuta1409 self-assigned this Mar 15, 2024
@Yuta1409 Yuta1409 requested a review from julesartd March 15, 2024 15:28
julesartd
julesartd requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@julesartd julesartd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, but you can separate the cards in the profile

julesartd
julesartd approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@julesartd julesartd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@julesartd julesartd merged commit 3baaf3c into dev Mar 15, 2024
1 check passed
@PHPLukaas PHPLukaas deleted the ui/configuration_menu branch April 2, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julesartd julesartd julesartd approved these changes

@PHPLukaas PHPLukaas Awaiting requested review from PHPLukaas

Assignees

@Yuta1409 Yuta1409

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat/Finish translations
2 participants
@Yuta1409 @julesartd