Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HybidSample running #6717

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Fix HybidSample running #6717

wants to merge 8 commits into from

Conversation

markmnl
Copy link

@markmnl markmnl commented Nov 23, 2023

Fixes:

  • yargs dependency missing, otherwise on fresh clone and npm install, npm start fails with this missing dependency
  • localhost URIs should be http as per README to match application registration
  • AADSTS70018 by removing extraQueryParameters.nativebroker from authCodeUrlParameters

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Nov 23, 2023
@markmnl
Copy link
Author

markmnl commented Nov 23, 2023

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jan 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jan 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 6, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalimasharda lalimasharda lalimasharda left review comments

@tnorling tnorling tnorling approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@sameerag sameerag

@konstantin-msft konstantin-msft

Labels
Needs: Attention 👋 Awaiting response from the MSAL.js team samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markmnl @tnorling @lalimasharda @sameerag @konstantin-msft @hectormmg