-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing window unavailable bugs for PCA and PBA (#7355)
Currently, the PCA constructor in 1P and some functions for PCA (both 1P and 3P) and PBA throw when the window is unavailable. This creates problems with server-side rendering. Additionally, some functions that should throw a non_browser_environment error when the window is unavailable (such as the acquireToken functions) throw a different error. This PR makes changes to prevent the PCA and PBA constructor and certain functions from throwing solely due to the window being unavailable and to ensure that the non_browser_environment error is thrown when appropriate. It also adds corresponding unit tests. --------- Co-authored-by: Hector Morales <[email protected]>
- Loading branch information
1 parent
f85b567
commit 243b68b
Showing
3 changed files
with
342 additions
and
27 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-browser-1aaf2555-690a-4057-bfad-d93a65f8e0ca.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Bug fixes for windowless PCA", | ||
"packageName": "@azure/msal-browser", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.