Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK readme with native authentication content #2051

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

Dickson-Mwendia
Copy link

@Dickson-Mwendia Dickson-Mwendia commented Mar 1, 2024

This PR updates the readme to include the native authentication capabilities for MSAL Android.

For the documentation updates and links:

  • We point to the official MSAL Android docs on MS Learn - https://learn.microsoft.com/en-us/entra/msal/android

  • Within the getting started section of the readme, we provide links to the different quickstarts/tutorials that devs can follow, based on their scenario and type of app they're building (workforce/customer)

  • I've also removed much of the content that's duplicated in the official docs (configuration, initialize client app, and acquire tokens) and instead pointed to the guidance on MS Learn, i.e:

As for the code samples, we also need to differentiate the between workforce and customer sample apps, that's why we have two links. Eventually, the links will point to the code samples browser, such as (https://learn.microsoft.com/en-us/samples/browse/?products=microsoft-authentication-library) I'm working to get all code samples for Android onboarded there.

@Dickson-Mwendia Dickson-Mwendia requested a review from a team as a code owner March 1, 2024 09:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@iamgusain
Copy link
Contributor

Let's add some description to the PR explaining what we are changing here and why.

@Dickson-Mwendia
Copy link
Author

Dickson-Mwendia commented Mar 11, 2024

@negoe @iamgusain could you please have another look at this?

Copy link

@henrymbuguakiarie henrymbuguakiarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Dickson-Mwendia,

I've left a couple of comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Dickson-Mwendia Dickson-Mwendia requested a review from a team March 27, 2024 12:09
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@negoe negoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dickson for the updates. I have provided my comments. The only main call out I have is the overall structure of the readme seems a bit confusing at the start. While reviewing, it's apparent that customers might become confused regarding the changes to Workforce identity support by MSAL. Previously, the term "Browser delegated auth" wasn't used, as it was the only default support for Workforce ID. Introducing this new term without initially clarifying what "browser delegated support" means, could be puzzling for customers. Also, please note that Ext ID supports both Browser delegated auth and Native Auth. Therefore, we need to explicitly clarify that here browser delegated auth is the original default support by MSAL for work/school and personal accounts.
Additionally, I would recommend setting the customer’s expectation from the beginning by stating that native auth is only supported in the case of Ext ID. You can pivot the document along the lines of: “To support External ID scenarios, we now offer Native authentication for better control over the design of the mobile application sign-in experiences.”

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Dickson-Mwendia
Copy link
Author

Thanks @negoe . I've updated the section that introduces native auth. Please have a look. Also, let me know what you think about renaming the H2 "Native authentication support in MSAL" and if this could bring more clarity to our customers.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants