Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD MSAL to DEV BROKER #1716

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Conversation

wainaina
Copy link
Contributor

@wainaina wainaina requested a review from a team as a code owner October 27, 2022 17:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022

Codecov Report

Merging #1716 (bceef57) into dev (3ac3354) will increase coverage by 0.66%.
The diff coverage is n/a.

❗ Current head bceef57 differs from pull request most recent head f0f37c4. Consider uploading reports for the commit f0f37c4 to get more accurate results

@@             Coverage Diff              @@
##                dev    #1716      +/-   ##
============================================
+ Coverage     48.89%   49.55%   +0.66%     
- Complexity      367      376       +9     
============================================
  Files            60       60              
  Lines          2712     2712              
  Branches        331      331              
============================================
+ Hits           1326     1344      +18     
+ Misses         1235     1224      -11     
+ Partials        151      144       -7     
Impacted Files Coverage Δ
...y/client/PublicClientApplicationConfiguration.java 28.44% <0.00%> (+0.88%) ⬆️
...osoft/identity/client/PublicClientApplication.java 44.14% <0.00%> (+0.96%) ⬆️
...tity/client/internal/CommandParametersAdapter.java 76.88% <0.00%> (+1.88%) ⬆️
...nt/internal/controllers/MSALControllerFactory.java 40.47% <0.00%> (+2.38%) ⬆️
.../com/microsoft/identity/client/AccountAdapter.java 94.16% <0.00%> (+4.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fadidurah
Copy link
Contributor

I think a lot of my comments on the other PR (https://github.com/AzureAD/android-complete/pull/162/) will also apply to this one. I don't want to spam this one as well :)

Copy link
Contributor

@shahzaibj shahzaibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Thanks @wainaina

@shahzaibj
Copy link
Contributor

Probably get a review from @fadidurah as well

@moumighosh
Copy link

@wainaina , are you planning to merge this PR, or abort it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants