-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD MSAL to DEV BROKER #1716
base: dev
Are you sure you want to change the base?
PROD MSAL to DEV BROKER #1716
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1716 +/- ##
============================================
+ Coverage 48.89% 49.55% +0.66%
- Complexity 367 376 +9
============================================
Files 60 60
Lines 2712 2712
Branches 331 331
============================================
+ Hits 1326 1344 +18
+ Misses 1235 1224 -11
+ Partials 151 144 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
azure-pipelines/ui-automation/msal-brokerProd-to-DevBroker-nightly.yml
Outdated
Show resolved
Hide resolved
I think a lot of my comments on the other PR (https://github.com/AzureAD/android-complete/pull/162/) will also apply to this one. I don't want to spam this one as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Thanks @wainaina
Probably get a review from @fadidurah as well |
@wainaina , are you planning to merge this PR, or abort it? |
Task: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/1254660
Create pipeline with the following configuration Prod MSAL - Dev BROKER
Pipeline for review URL: https://identitydivision.visualstudio.com/Engineering/_build?definitionId=1791&_a=summary