Close resources after reading the config file. (#520)

* Close resources after read. * Warn instead of verbose
AzureAD · Feb 5, 2019 · 7941fda · 7941fda
1 parent 8925680
commit 7941fda
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/msal/src/main/java/com/microsoft/identity/client/PublicClientApplication.java b/msal/src/main/java/com/microsoft/identity/client/PublicClientApplication.java
@@ -1066,6 +1066,23 @@ private static PublicClientApplicationConfiguration loadConfiguration(InputStrea
                 throw new IllegalArgumentException("Unable to open provided configuration file.", e);
             }
         }
+        finally {
+            try {
+                configStream.close();
+            } catch (IOException e) {
+                if (isDefaultConfiguration) {
+                    com.microsoft.identity.common.internal.logging.Logger.warn(
+                        TAG + "loadConfiguration",
+                        "Unable to close default configuration file. This can cause memory leak."
+                    );
+                } else {
+                    com.microsoft.identity.common.internal.logging.Logger.warn(
+                            TAG + "loadConfiguration",
+                            "Unable to close provided configuration file. This can cause memory leak."
+                    );
+                }
+            }
+        }
 
         final String config = new String(buffer);
         final Gson gson = getGsonForLoadingConfiguration();
@@ -1203,4 +1220,4 @@ public void onCancel() {
     private OAuth2TokenCache<?, ?, ?> getOAuth2TokenCache() {
         return initCommonCache(mPublicClientConfiguration.getAppContext());
     }
-}
+}