Allow to specify a private_dns_zone_id #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
1 task
|
it looks good to me - i initially misread and thought the RBAC was in the module, but I see it is in the example my bad. I think it is important modules support ALZs. After all, beautifully crafted LZs with all the policies and CAF practices is what we should be deploying into (oh look, there goes a unicorn 😸). edit - a minor point - I think the variable should set Good to see this being incorporated. 🚀 |
|
@nellyk please final review and merge. end 2 end tests are passing. |
nellyk
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #136
Closes #136