add azurelinux as an option for the os type #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
nellyk
commented
Oct 2, 2024
| @@ -254,7 +253,6 @@ map(object({ | |||
| os_disk_size_gb = optional(number, null) | |||
| tags = optional(map(string), {}) | |||
| labels = optional(map(string), {}) | |||
| zones = optional(set(string)) | |||
There was a problem hiding this comment.
i've removed this, based on your comment
nellyk
commented
Oct 2, 2024
| @@ -64,7 +64,7 @@ module "test" { | |||
| orchestrator_version = "1.28" | |||
| max_count = 110 | |||
| min_count = 2 | |||
| os_sku = "Ubuntu" | |||
| os_sku = "AzureLinux" | |||
There was a problem hiding this comment.
What do you mean "for testing" ?
There was a problem hiding this comment.
no longer need this, i added this to test out a user providing Azure linux when we had set ubuntu to default initially
nellyk
force-pushed
the
issue/azure-linux
branch
from
c118f90 to
47cefb3
Compare
nellyk
force-pushed
the
issue/azure-linux
branch
from
47cefb3 to
214df4a
Compare
nellyk
force-pushed
the
issue/azure-linux
branch
from
214df4a to
f2b5019
Compare
zioproto
reviewed
Oct 4, 2024
zioproto
previously approved these changes
Oct 4, 2024
zioproto
force-pushed
the
issue/azure-linux
branch
from
f2b5019 to
a5a8289
Compare
zioproto
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #113
closes #113