Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repository governance #111

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: repository governance #111

merged 1 commit into from
Sep 17, 2024

Conversation

segraef
Copy link
Contributor

@segraef segraef commented Sep 15, 2024

Repository governance update

This PR was automatically created by the AVM Team hive-mind using the grept governance tool.

We have detected that some files need updating to meet the AVM governance standards.
Please review and merge with alacrity.

Grept config source: git::https://github.com/Azure/Azure-Verified-Modules-Grept.git//terraform

Thanks! The AVM team ❤️


run-e2e-tests:
if: github.event.repository.name != 'terraform-azurerm-avm-template' && github.event.pull_request.head.repo.fork == false
uses: Azure/terraform-azurerm-avm-template/.github/workflows/test-examples-template.yml@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a tag here instead of main ? We dont want to see things breaking without any apparent change, and in case of unexpected bugs it is hard to fix without having a way to rollback.

@segraef @nellyk @lonegunmanb @mbilalamjad @matt-FFFFFF

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We considered this but will leave as @main for now. We can git revert or fast fix if we need to. The whole team can fix issues if they get reported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add to this and provide some insight. We will very likely move this template to a separate repository in the coming months and at that point we will specify a commit here. We had to add this quickly and wanted to be able to make updates in the short term. We have more work planned to harden it.

@zioproto zioproto merged commit db707df into main Sep 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants