Skip to content

Commit

Permalink
fix node taints
Browse files Browse the repository at this point in the history
  • Loading branch information
nellyk committed Oct 16, 2024
1 parent 0f7461e commit 96f3a73
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ map(object({
os\_disk\_size\_gb = (Optional) The Agent Operating System disk size in GB. Changing this forces a new resource to be created.
tags = (Optional) A mapping of tags to assign to the resource. At this time there's a bug in the AKS API where Tags for a Node Pool are not stored in the correct case - you [may wish to use Terraform's `ignore_changes` functionality to ignore changes to the casing](https://www.terraform.io/language/meta-arguments/lifecycle#ignore_changess) until this is fixed in the AKS API.
labels = (Optional) A map of Kubernetes labels which should be applied to nodes in this Node Pool.
taints = (Optional) A list of the taints added to new nodes during node pool create and scale.
node\_taints = (Optional) A list of the taints added to new nodes during node pool create and scale.
}))

Example input:
Expand Down Expand Up @@ -269,7 +269,7 @@ map(object({
os_disk_size_gb = optional(number, null)
tags = optional(map(string), {})
labels = optional(map(string), {})
taints = list(string)
node_taints = optional(list(string), null)
}))
```

Expand All @@ -281,7 +281,7 @@ Description: (Optional) A list of the taints added to new nodes during node pool

Type: `list(string)`

Default: `{}`
Default: `null`

### <a name="input_orchestrator_version"></a> [orchestrator\_version](#input\_orchestrator\_version)

Expand Down
2 changes: 1 addition & 1 deletion locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ locals {
max_count = pool.max_count
min_count = pool.min_count
labels = pool.labels
taint = pool.taints
node_taints = pool.node_taints
os_sku = pool.os_sku
mode = pool.mode
os_disk_size_gb = pool.os_disk_size_gb
Expand Down
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ resource "azurerm_kubernetes_cluster_node_pool" "this" {
max_count = each.value.max_count
min_count = each.value.min_count
node_labels = each.value.labels
node_taints = each.value.taints
node_taints = each.value.node_taints
orchestrator_version = each.value.orchestrator_version
os_disk_size_gb = each.value.os_disk_size_gb
os_sku = each.value.os_sku
Expand Down
6 changes: 3 additions & 3 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ variable "node_pools" {
os_disk_size_gb = optional(number, null)
tags = optional(map(string), {})
labels = optional(map(string), {})
taints = list(string)
node_taints = optional(list(string), null)
}))
default = {}
description = <<-EOT
Expand All @@ -149,7 +149,7 @@ map(object({
os_disk_size_gb = (Optional) The Agent Operating System disk size in GB. Changing this forces a new resource to be created.
tags = (Optional) A mapping of tags to assign to the resource. At this time there's a bug in the AKS API where Tags for a Node Pool are not stored in the correct case - you [may wish to use Terraform's `ignore_changes` functionality to ignore changes to the casing](https://www.terraform.io/language/meta-arguments/lifecycle#ignore_changess) until this is fixed in the AKS API.
labels = (Optional) A map of Kubernetes labels which should be applied to nodes in this Node Pool.
taints = (Optional) A list of the taints added to new nodes during node pool create and scale.
node_taints = (Optional) A list of the taints added to new nodes during node pool create and scale.
}))
Example input:
Expand Down Expand Up @@ -186,7 +186,7 @@ EOT

variable "node_taints" {
type = list(string)
default = {}
default = null
description = "(Optional) A list of the taints added to new nodes during node pool create and scale. Changing this forces a new resource to be created."
}

Expand Down

0 comments on commit 96f3a73

Please sign in to comment.