Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding timeout to the rollout status #353

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

adding timeout to the rollout status #353

wants to merge 5 commits into from

Conversation

Vidya2606
Copy link
Contributor

@Vidya2606 Vidya2606 commented Nov 19, 2024 •
edited
Loading

Adding timeout to the rollout status - #350

@Vidya2606 Vidya2606 requested a review from a team as a code owner November 19, 2024 23:24
@davidgamero
Copy link
Collaborator

davidgamero commented Nov 20, 2024 •
edited
Loading

this looks good.
let's add the input to action.yaml so it can be configured by users
this means it will be retrieved in run.ts via core.getInput and then passed down to the functions that use it.

also, let's default to a longer default timeout input in action.yaml like 10m

davidgamero
davidgamero approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamero davidgamero davidgamero approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vidya2606 @davidgamero